Hamish can you clarify? The results are currently still calling the Valves V1, etc and that is presumably because the config.py files deployed still lag behind the latest versions in GitLab.hamishmb wrote: ↑21/08/2020, 19:02Note: We need to update the software design spec again to add:
- New IDs for gate valve pis (eg VALVE4 instead of V4).
- ^ And corresponding detail for the ID for the gate valve itself (still eg V4 or V6).
- New notes from config.py docstring (perhaps that docstring should just link to this document?)
So how do you want to represent this in the Software Design Spec? Currently the ID is in the column labelled Device Name. Would you like the full ID, as it appears in Config.py, to be in that column or is it sufficient to put an additional Note to cover this?
With the docstring request. wouldn't the reference have to be in this document, so future maintainers are aware that it is there? Or perhaps both?